Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added DC personalities for some meters to affected files #308

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

dmiskovic-NV
Copy link
Contributor

adding changes mentioned in #305

@dmiskovic-NV dmiskovic-NV requested a review from a team as a code owner May 18, 2023 13:14
@github-actions
Copy link

github-actions bot commented May 18, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@arjunsuresh arjunsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Dejan for these changes.

@dmiskovic-NV
Copy link
Contributor Author

Please review and merge. All changes needed to get DC running are in this PR

araghun
araghun previously approved these changes Nov 21, 2023
Copy link
Contributor

@araghun araghun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as discussed in PowerWG 11/21

@dmiskovic-NV dmiskovic-NV dismissed araghun’s stale review November 21, 2023 23:33

The merge-base changed after approval.

Copy link
Contributor

@araghun araghun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as discussed in PowerWG 11/21

araghun
araghun previously approved these changes Nov 21, 2023
Copy link
Contributor

@araghun araghun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as discussed in PowerWG 11/21

@araghun
Copy link
Contributor

araghun commented Nov 21, 2023

Not sure who has to approve this to be merged.

@dmiskovic-NV dmiskovic-NV dismissed araghun’s stale review November 21, 2023 23:59

The merge-base changed after approval.

araghun
araghun previously approved these changes Nov 28, 2023
@dmiskovic-NV dmiskovic-NV dismissed araghun’s stale review November 28, 2023 23:11

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants