-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support find cache + gh action for core mlc actions #39
base: dev
Are you sure you want to change the base?
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
||
- name: Test find cache - Cache not present | ||
run: | | ||
mlc find cache --tags=detect,os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are we checking the output here?
|
||
- name: Test run script - Output being used for testing mlc cache | ||
run: | | ||
mlc run script --tags=get,imagenet-aux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its better to always use "--quiet" in the github actions as otherwise any prompt can fail the action.
The changes proposed are to support
mlc find cache
command in MLC and to initiate the GitHub action for testing the core MLC actions.After merging the PR, it may be observed that there are duplicate print statements of WARNING - No cache entry found for the specified tags! are being found when executing a script. Example is given below:
This is due to the automation script in
mlperf-automations
repo calling thefind
action of MLC.@arjunsuresh , would it be a good solution that we replace the calling of
find
action inmlperf-automation
tosearch
?