Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support find cache + gh action for core mlc actions #39

Draft
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

anandhu-eng
Copy link
Contributor

@anandhu-eng anandhu-eng commented Jan 25, 2025

The changes proposed are to support mlc find cache command in MLC and to initiate the GitHub action for testing the core MLC actions.

After merging the PR, it may be observed that there are duplicate print statements of WARNING - No cache entry found for the specified tags! are being found when executing a script. Example is given below:

anandhu@anandhu-VivoBook-ASUSLaptop-X515UA-M515UA:~/Music/mlcflow$ python3 -m mlc.main run script --tags=get,imagenet-aux,_from.dropbox
/usr/lib/python3.10/runpy.py:126: RuntimeWarning: 'mlc.main' found in sys.modules after import of package 'mlc', but prior to execution of 'mlc.main'; this may result in unpredictable behaviour
  warn(RuntimeWarning(msg))
2025-01-25 12:02:51,613 - __main__ - INFO - Repos path for Index: /home/anandhu/MLC/repos
2025-01-25 12:02:56,361 - __main__ - INFO - Shared index for script saved to /home/anandhu/MLC/repos/index_script.json.
2025-01-25 12:02:56,363 - __main__ - INFO - Shared index for cache saved to /home/anandhu/MLC/repos/index_cache.json.
2025-01-25 12:02:56,363 - __main__ - INFO - Shared index for experiment saved to /home/anandhu/MLC/repos/index_experiment.json.
2025-01-25 12:02:56,383 - root - INFO - * mlc run script --tags=get,imagenet-aux,_from.dropbox
2025-01-25 12:02:56,384 - __main__ - WARNING - No cache entry found for the specified tags!
2025-01-25 12:02:56,384 - __main__ - WARNING - No cache entry found for the specified tags!
2025-01-25 12:02:56,413 - root - INFO -   * mlc run script --tags=download-and-extract,_extract,_wget,_url.https://www.dropbox.com/s/92n2fyej3lzy3s3/caffe_ilsvrc12.tar.gz
2025-01-25 12:02:56,413 - __main__ - WARNING - No cache entry found for the specified tags!
2025-01-25 12:02:56,420 - __main__ - WARNING - No cache entry found for the specified tags!
2025-01-25 12:02:56,450 - root - INFO -     * mlc run script --tags=download,file,_wget,_url.https://www.dropbox.com/s/92n2fyej3lzy3s3/caffe_ilsvrc12.tar.gz
2025-01-25 12:02:56,450 - __main__ - WARNING - No cache entry found for the specified tags!
2025-01-25 12:02:56,451 - __main__ - WARNING - No cache entry found for the specified tags!
2025-01-25 12:02:56,466 - root - INFO -       * mlc run script --tags=detect,os
2025-01-25 12:02:56,474 - root - INFO -              ! cd /home/anandhu/MLC/repos/local/cache/download-file_e233ea24
2025-01-25 12:02:56,474 - root - INFO -              ! call /home/anandhu/MLC/repos/mlcommons@mlperf-automations/script/detect-os/run.sh from tmp-run.sh
2025-01-25 12:02:56,521 - root - INFO -              ! call "postprocess" from /ho

This is due to the automation script in mlperf-automations repo calling the find action of MLC.

@arjunsuresh , would it be a good solution that we replace the calling of find action in mlperf-automation to search?

@anandhu-eng anandhu-eng requested a review from a team as a code owner January 25, 2025 07:09
Copy link

github-actions bot commented Jan 25, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅


- name: Test find cache - Cache not present
run: |
mlc find cache --tags=detect,os
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how are we checking the output here?


- name: Test run script - Output being used for testing mlc cache
run: |
mlc run script --tags=get,imagenet-aux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its better to always use "--quiet" in the github actions as otherwise any prompt can fail the action.

@anandhu-eng anandhu-eng marked this pull request as draft January 25, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants