prevent empty statistics file

[mhmdk0]

Fixes #623

[github-actions]

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

[aristizabal95]

Looks good! Amazing work @mhmdk0! My only suggestion if possible would be to use the mocked filesystem for testing, instead of patching open and write. This is because those operations are pretty common, and scattered throughout our codebase. If future changes will call those methods in other portions of the tested function then those patches would introduce side effects that will be difficult to figure out.

You can refer to this example:

medperf/cli/medperf/tests/entities/utils.py

Lines 55 to 70 in ea5a576

	def setup_cube_fs(ents, fs):
	for ent in ents:
	# Assume we're passing ids, names, or dicts
	if isinstance(ent, dict):
	cube = TestCube(**ent)
	elif isinstance(ent, int) or isinstance(ent, str) and ent.isdigit():
	cube = TestCube(id=str(ent))
	else:
	cube = TestCube(id=None, name=ent)
	meta_cube_file = os.path.join(cube.path, config.cube_metadata_filename)
	meta = cube.todict()
	try:
	fs.create_file(meta_cube_file, contents=yaml.dump(meta))
	except FileExistsError:
	pass

As well as to the documentation of pyfakefs: https://pytest-pyfakefs.readthedocs.io/en/stable/usage.html#test-scenarios

If this is too cumbersome you can also leave it as is and create an issue as a reminder for later.

[mhmdk0]

Looks good! Amazing work @mhmdk0! My only suggestion if possible would be to use the mocked filesystem for testing, instead of patching open and write. This is because those operations are pretty common, and scattered throughout our codebase. If future changes will call those methods in other portions of the tested function then those patches would introduce side effects that will be difficult to figure out.

Much thanks @aristizabal95 ! I’ll review and finalize it soon. I really appreciate you providing both the example and the documentation.

[mhmdk0]

@aristizabal95 Just modified the tests to use fake fs instead of patching builtins.open. Thanks for informing me about this.

[aristizabal95]

Awesome! Looks great!