-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web UI - stage1, readonly part #606
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
# Conflicts: # cli/medperf/commands/list.py # cli/medperf/entities/benchmark.py # cli/medperf/entities/cube.py # cli/medperf/entities/dataset.py # cli/medperf/entities/interface.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! There is a little bit of repeated code in the FastAPI routers for listing objects, but is manageable and something that can be improved later on
<link rel="stylesheet" href="/static/css/font-awesome-5.15.4-all.min.css"> | ||
<!-- https://cdnjs.cloudflare.com/ajax/libs/prism/1.23.0/themes/prism.min.css --> | ||
<link rel="stylesheet" href="/static/css/prism-1.23.0.min.css"> | ||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to put this in a separate css file? It feels like this has too much content to be inserted as an inline style instruction
Adds a local web UI to use instead of CLI UI.
On this stage, only read-only views are implemented:
To run
TODOs & bugs up to this moment
mlcube-as-a-link
and use everywhere (benchmark's cubes, dataset's dataprep cube):[strong] mlcube name
[small] modified date
[state icon]
+ colored in red if invalid?None
linksowner: None
? Show a hint over it describing why it's unknown?