Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codespaces #521

Merged
merged 30 commits into from
Jan 21, 2024
Merged

Codespaces #521

merged 30 commits into from
Jan 21, 2024

Conversation

VukW
Copy link
Contributor

@VukW VukW commented Jan 12, 2024

Added devconfig for running medperf in codespace.

  1. raised PyYAML dependency to support py3.10
  2. Neat point: the codespace is created once per user per branch, and medperf repo is attached only on the creation. Thus, the state of user's codespace is persistent despite of new commits to main branch. Therefore, if we commit anything, users have to recreate the codespace to get updated version.

@VukW VukW requested a review from a team as a code owner January 12, 2024 19:41
@VukW VukW had a problem deploying to testing-external-code January 12, 2024 19:41 — with GitHub Actions Failure
Copy link
Contributor

github-actions bot commented Jan 12, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@VukW VukW had a problem deploying to testing-external-code January 18, 2024 10:24 — with GitHub Actions Failure
@VukW VukW had a problem deploying to testing-external-code January 18, 2024 15:25 — with GitHub Actions Failure
@hasan7n hasan7n had a problem deploying to testing-external-code January 19, 2024 11:48 — with GitHub Actions Failure
hasan7n
hasan7n previously approved these changes Jan 19, 2024
Copy link
Contributor

@hasan7n hasan7n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work man!

@hasan7n hasan7n had a problem deploying to testing-external-code January 19, 2024 12:01 — with GitHub Actions Failure
@hasan7n hasan7n self-requested a review January 19, 2024 12:01
@VukW VukW merged commit c483929 into mlcommons:main Jan 21, 2024
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants