-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Data Preparation logic for manual steps #486
Merged
hasan7n
merged 247 commits into
mlcommons:main
from
aristizabal95:data-prep-manual-steps
Mar 15, 2024
Merged
Implement Data Preparation logic for manual steps #486
hasan7n
merged 247 commits into
mlcommons:main
from
aristizabal95:data-prep-manual-steps
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristizabal95
had a problem deploying
to
testing-external-code
February 5, 2024 22:45 — with
GitHub Actions
Failure
hasan7n
had a problem deploying
to
testing-external-code
February 7, 2024 11:09 — with
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
February 8, 2024 16:00 — with
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
February 19, 2024 17:15 — with
GitHub Actions
Failure
fix integration test not having all cubes as operational
aristizabal95
had a problem deploying
to
testing-external-code
February 21, 2024 19:07 — with
GitHub Actions
Failure
polish multithreading in dataset prepare
aristizabal95
had a problem deploying
to
testing-external-code
February 22, 2024 17:07 — with
GitHub Actions
Failure
aristizabal95
had a problem deploying
to
testing-external-code
February 22, 2024 17:13 — with
GitHub Actions
Failure
aristizabal95
temporarily deployed
to
testing-external-code
February 22, 2024 17:34 — with
GitHub Actions
Inactive
recover lost config variables
Update data branch to latest changes
aristizabal95
requested a deployment
to
testing-external-code
March 5, 2024 15:57 — with
GitHub Actions
Waiting
hasan7n
temporarily deployed
to
testing-external-code
March 15, 2024 04:18 — with
GitHub Actions
Inactive
hasan7n
approved these changes
Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the required logic for handling Data Preparation workflows where manual steps are needed in between. This is done by storing not-yet-prepared datasets in a staging folder, and allowing the user to resume preparation by using the same dataset name. Datasets now also create a report file containing information about the execution, and medperf automatically generates a summary for the user to determine what to do in case of errors or manual steps.
Closes #506