Skip to content

Commit

Permalink
update how association ls is used in tests and docs
Browse files Browse the repository at this point in the history
  • Loading branch information
hasan7n committed Nov 25, 2024
1 parent ca51d58 commit 959711d
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
3 changes: 1 addition & 2 deletions cli/cli_chestxray_tutorial_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ chmod a+w $DIRECTORY/sample_raw_data

##########################################################


echo "=========================================="
echo "Creating test profiles for each user"
echo "=========================================="
Expand Down Expand Up @@ -84,7 +83,7 @@ echo "====================================="
print_eval medperf profile activate testbenchmark
checkFailed "testbenchmark profile activation failed"
# Get association information
ASSOC_INFO=$(medperf association ls | head -n 4 | tail -n 1 | tr -s ' ')
ASSOC_INFO=$(medperf association ls -bd | head -n 4 | tail -n 1 | tr -s ' ')
ASSOC_DSET_UID=$(echo $ASSOC_INFO | cut -d ' ' -f 1)
ASSOC_BMK_UID=$(echo $ASSOC_INFO | cut -d ' ' -f 2)
# Mark dataset-benchmark association as approved
Expand Down
6 changes: 4 additions & 2 deletions cli/cli_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,10 @@ echo "\n"
echo "======================================================"
echo "Submitted associations:"
echo "======================================================"
print_eval medperf association ls
checkFailed "Listing associations failed"
print_eval medperf association ls -bd
checkFailed "Listing benchmark-datasets associations failed"
print_eval medperf association ls -bm
checkFailed "Listing benchmark-models associations failed"
##########################################################

echo "\n"
Expand Down
4 changes: 2 additions & 2 deletions docs/getting_started/data_owner_demo.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,15 @@ This command will first run the benchmark's reference model on your dataset to e
#### How to proceed after requesting association

![Benchmark Committee accepts / rejects datasets](../tutorial_images/do-4-bc-accepts-rejects-datasets.png){class="tutorial-sticky-image-content"}
When participating with a real benchmark, you must wait for the Benchmark Committee to approve the association request. You can check the status of your association requests by running `medperf association ls`. The association is identified by the server UIDs of your dataset and the benchmark with which you are requesting association.
When participating with a real benchmark, you must wait for the Benchmark Committee to approve the association request. You can check the status of your association requests by running `medperf association ls -bd`. The association is identified by the server UIDs of your dataset and the benchmark with which you are requesting association.

_For the sake of continuing the tutorial only_, run the following to simulate the benchmark committee approving your association (make sure you are in the MedPerf's root directory):

```bash
sh tutorials_scripts/simulate_data_association_approval.sh
```

You can verify if your association request has been approved by running `medperf association ls`.
You can verify if your association request has been approved by running `medperf association ls -bd`.

## 5. Execute the Benchmark

Expand Down
2 changes: 1 addition & 1 deletion docs/getting_started/model_owner_demo.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ This command will first run the benchmark's workflow on your model to ensure you
#### What Happens After Requesting the Association?

![Benchmark Committee accepts / rejects models](../tutorial_images/mo-4-bc-accepts-rejects-models.png){class="tutorial-sticky-image-content"}
When participating with a real benchmark, you must wait for the Benchmark Committee to approve the association request. You can check the status of your association requests by running `medperf association ls`. The association is identified by the server UIDs of your MLCube and the benchmark with which you are requesting association.
When participating with a real benchmark, you must wait for the Benchmark Committee to approve the association request. You can check the status of your association requests by running `medperf association ls -bm`. The association is identified by the server UIDs of your MLCube and the benchmark with which you are requesting association.

![The end](../tutorial_images/the-end.png){class="tutorial-sticky-image-content"}
{% include "getting_started/shared/cleanup.md" %}

0 comments on commit 959711d

Please sign in to comment.