Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end on device support to Loadgen #952

Merged
merged 8 commits into from
Jun 22, 2021

Conversation

nvitramble
Copy link
Contributor

Adds optional callback argument to QuerySamplesComplete() which will allow the user to perform a accelerator->host copy after timing the query response time and before logging the response data for accuracy mode.

Discussed in mlcommons/inference_policies#213.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2021

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@nvpohanh
Copy link
Contributor

@guschmue This looks like an infra issue:

[2021-06-14 22:13:36] [build-stderr] Traceback (most recent call last):
[2021-06-14 22:13:36] [build-stderr]   File "setup.py", line 29, in <module>
[2021-06-14 22:13:36] [build-stderr]     from version_generator import generate_loadgen_version_definitions
[2021-06-14 22:13:36] [build-stderr]   File "/opt/src/loadgen/version_generator.py", line 25, in <module>
[2021-06-14 22:13:36] [build-stderr]     from absl import app
[2021-06-14 22:13:36] [build-stderr] ImportError: No module named absl

@guschmue
Copy link
Contributor

I can take a look at absl, probably some dependency missing in setup.py

@guschmue
Copy link
Contributor

@nvpohanh - good to with you to merge this PR?

@guschmue
Copy link
Contributor

PR with the fix for the absl dependency is here #952

Copy link
Contributor

@nvpohanh nvpohanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for implementing this!

@nvpohanh
Copy link
Contributor

@guschmue we can merge this

@guschmue guschmue merged commit ce8a24a into mlcommons:master Jun 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants