Improved CM commands #2013
Closed
Improved CM commands #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
arjunsuresh
requested changes
Jan 7, 2025
language/bert/README.md
Outdated
| @@ -55,7 +55,8 @@ The below CM command will launch the SUT server | |||
|
|
|||
| ``` | |||
| cm run script --tags=generate-run-cmds,inference --model=bert-99 --backend=pytorch \ | |||
| --mode=performance --device=cuda --quiet --test_query_count=1000 --network=sut | |||
| --mode=performance --device=cuda --quiet --test_query_count=1000 --network=sut \ | |||
| --outdirname=results/bert-99-performance | |||
There was a problem hiding this comment.
Whats the use of --outdirname here?
text_to_image/README.md
Outdated
|
|
||
| **`fp32`** | ||
| ``` | ||
| rclone copy mlc-inference:mlcommons-inference-wg-public/stable_diffusion_fp32 ./stable_diffusion_fp32 -P | ||
| rclone copy mlc-inference:mlcommons-inference-wg-public/stable_diffusion_fp32 $MODEL_PATH -P |
There was a problem hiding this comment.
We are already inside $MODEL_PATH after cd $MODEL_PATH
tools/upscale_coco/coco.py
Outdated
| @@ -317,7 +317,7 @@ def showAnns(self, anns): | |||
| v = kp[2::3] | |||
| for sk in sks: | |||
| if np.all(v[sk] > 0): | |||
| plt.plot(x[sk], y[sk], linewidth=3, color=c) | |||
| plt.plot(x[sk], y[sk], linewidth=3, color=c,label=f"keypoint {sk}") | |||
There was a problem hiding this comment.
what's the change done here?
anandhu-eng
reviewed
Jan 23, 2025
| @@ -317,7 +317,17 @@ def showAnns(self, anns): | |||
| v = kp[2::3] | |||
| for sk in sks: | |||
| if np.all(v[sk] > 0): | |||
|
|
|||
|
|
|||
| << << << < HEAD | |||
There was a problem hiding this comment.
Came while resolving merge conflict?
anandhu-eng
reviewed
Jan 23, 2025
| @@ -318,6 +318,15 @@ def showAnns(self, anns): | |||
| for sk in sks: | |||
| if np.all(v[sk] > 0): | |||
| plt.plot(x[sk], y[sk], linewidth=3, color=c) | |||
|
|
|||
|
|
|||
| == == == = | |||
anandhu-eng
reviewed
Jan 23, 2025
| color=c) | ||
|
|
||
|
|
||
| >>>>>> > 6bc50d8f7c0ee1c553aabe2d40c9534e7529b620 |
anandhu-eng
reviewed
Jan 23, 2025
| @@ -318,6 +318,14 @@ def showAnns(self, anns): | |||
| for sk in sks: | |||
| if np.all(v[sk] > 0): | |||
| plt.plot(x[sk], y[sk], linewidth=3, color=c) | |||
| plt.plot( | |||
There was a problem hiding this comment.
Hi @sahilavaran , is there a particular reason we need to duplicate line 320 and 321?
|
There are some issues here, i am creating a new one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.