Remove backwards compatibility for the submission checker. Update sub… #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
Thanks Arjun, I think we are okay with the change as long as it doesn't break the behavior of 4.0 and 4.1 existing benchmarks. Have you tested the workloads? |
|
Thank you @nvzhihanj for reviewing. Yes, it is tested for 4.0 submission repo by the github action. |
|
@mrmhodak NVIDIA members experienced with submission checker also agreed that we can drop the backwards compatibility and thus simplify the submission checker a lot. Arjun's PR is a good idea and we approve. |
mrmhodak
approved these changes
May 21, 2024
…mission_checker.py It makes sense to remove the backwards compatibility of the submission checker in the master branch. We can always use a specific release of the inference repository to get the submission checker for that round of submission.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mission_checker.py
It makes sense to remove the backwards compatibility of the submission checker in the master branch. We can always use a specific release of the inference repository to get the submission checker for that round of submission.