Fix reporting of samples per queries with equal issue mode

mlcommons · Jan 15, 2025 · 329f43c · 329f43c
1 parent ab7f700
commit 329f43c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/loadgen/loadgen.cc b/loadgen/loadgen.cc
@@ -421,7 +421,7 @@ std::vector<QueryMetadata> GenerateQueries(
     }
   }
 
-  LogDetail([count = queries.size(), spq = settings.samples_per_query,
+  LogDetail([count = queries.size(), spq = samples_per_query,
              duration = timestamp.count()](AsyncDetail& detail) {
 #if USE_NEW_LOGGING_FORMAT
     MLPERF_LOG(detail, "generated_query_count", count);

diff --git a/loadgen/test_settings_internal.cc b/loadgen/test_settings_internal.cc
@@ -515,6 +515,12 @@ void TestSettingsInternal::LogSummary(AsyncSummary &summary) const {
   summary("performance_issue_same : ", performance_issue_same);
   summary("performance_issue_same_index : ", performance_issue_same_index);
   summary("performance_sample_count : ", performance_sample_count);
+  if (sample_concatenate_permutation){
+    summary("WARNING: sample_concatenate_permutation was set to true. \n"
+            "Generated samples per query might be different as the one in the setting.\n"
+            "Check the generated_samples_per_query line in the detailed log for the real\n"
+            "samples_per_query value");
+  }
 }
 
 }  // namespace loadgen