Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstrings and enhance help messages in visualizer #93

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

TaekyungHeo
Copy link
Contributor

Summary

Add docstrings and enhance help messages in visualizer

Test Plan

$ chakra_visualizer --help
usage: chakra_visualizer [-h] --input_filename INPUT_FILENAME --output_filename OUTPUT_FILENAME

Execution Trace Visualizer

options:
  -h, --help            show this help message and exit
  --input_filename INPUT_FILENAME
                        Input Chakra execution trace filename
  --output_filename OUTPUT_FILENAME
                        Output graph filename. Supported extensions are pdf, dot, and graphml. Recommend
                        using graphml for large graphs for rendering speed.
$ chakra_visualizer --input_filename megatron_0.chakra --output_filename megatron_0.graphml 
$ head megatron_0.graphml 
<?xml version='1.0' encoding='utf-8'?>
<graphml xmlns="http://graphml.graphdrawing.org/xmlns" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://graphml.graphdrawing.org/xmlns http://graphml.graphdrawing.org/xmlns/1.0/graphml.xsd">
  <key id="d1" for="edge" attr.name="dependency" attr.type="string" />
  <key id="d0" for="node" attr.name="label" attr.type="string" />
  <graph edgedefault="directed">
    <node id="1">
      <data key="d0">[pytorch|profiler|execution_trace|thread]</data>
    </node>
    <node id="0" />
    <node id="2">

@TaekyungHeo TaekyungHeo requested a review from a team as a code owner June 11, 2024 13:47
Copy link

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@srinivas212 srinivas212 merged commit c395bb2 into main Jun 11, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
@TaekyungHeo TaekyungHeo deleted the visualizer-refactor branch June 11, 2024 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants