Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix is_cpu_op bug #159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix is_cpu_op bug #159

wants to merge 1 commit into from

Conversation

yue2388253
Copy link

Summary

Converting ASTRA-sim 1.0 text input files does not add is_cpu_op field. As a result, the COMM nodes are always skipped by the workload layer of astra-sim, as reported in #144 and astra-sim/astra-sim#224.
Simply adding the attribute might fix the bug.

@yue2388253 yue2388253 requested a review from a team as a code owner October 10, 2024 14:24
Copy link

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact [email protected].
0 out of 1 committers have signed the MLCommons CLA.
@yue2388253
You can retrigger this bot by commenting recheck in this Pull Request

@willjwon
Copy link

Thanks for your contribution, @yue2388253. We acknowledge this problem and would like to merge this in, once you sign the CLA form (https://drive.google.com/file/d/1SkpAdb3ka8tXepCawgGxAyo6cUH5ZAZg/view). Could you please do so?

@yue2388253
Copy link
Author

Thanks for your contribution, @yue2388253. We acknowledge this problem and would like to merge this in, once you sign the CLA form (https://drive.google.com/file/d/1SkpAdb3ka8tXepCawgGxAyo6cUH5ZAZg/view). Could you please do so?

Hi @willjwon, I have submitted the CLA form as requested. Could you kindly review and confirm if the PR is ready for merging?

Thank you for your time and consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants