Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds: AMD hipLaunch kernels to the is_cuda_op function #129

Closed
wants to merge 1 commit into from
Closed

Adds: AMD hipLaunch kernels to the is_cuda_op function #129

wants to merge 1 commit into from

Conversation

rohitdwivedula
Copy link

See #128 for context.

@rohitdwivedula rohitdwivedula requested a review from a team as a code owner July 11, 2024 19:54
Copy link

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact [email protected].
0 out of 1 committers have signed the MLCommons CLA.
@Rohit Dwivedula
Rohit Dwivedula seems not to be a GitHub user. You need a GitHub account after you become MLCommons member. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@TaekyungHeo
Copy link
Contributor

TaekyungHeo commented Jul 12, 2024

Thanks for the PR, @rohitdwivedula. First, please sign the CLA to contribute to the Chakra project. Second, I agree that the Chakra toolchains support AMD GPUs. However, the current changes are not ideal. For example, you are introducing AMD GPU keywords in is_cuda_launch_op. We need to better organize our code for generality. Moreover, there are some pending PRs to be merged. It will save your time if you can rebase your PR after the other PRs are merged.

Lastly, please follow the PR template and provide a proper test plan to demonstrate that this PR supports Chakra traces collected from AMD GPUs.

@rohitdwivedula rohitdwivedula closed this by deleting the head repository Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants