Encode is_cpu_op as a boolean value in the converter #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
TaekyungHeo
force-pushed
the
feeder-bug-fix
branch
from
d153f95 to
0992d1d
Compare
TaekyungHeo
force-pushed
the
feeder-bug-fix
branch
2 times, most recently
from
4ed5bc9 to
8109eac
Compare
TaekyungHeo
changed the title
TaekyungHeo
force-pushed
the
feeder-bug-fix
branch
2 times, most recently
from
32ab6b4 to
5f8a3b6
Compare
TaekyungHeo
force-pushed
the
feeder-bug-fix
branch
from
5f8a3b6 to
6e98660
Compare
srinivas212
approved these changes
Jul 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Encode is_cpu_op as a boolean value in the converter. Previously, the converter encoded is_cpu_op as an int32_t, which led to a bug in the parsing logic and the CI pipelines. This PR fixes the bug and correctly encodes is_cpu_op as a boolean value.
Test Plan