Skip to content

Commit

Permalink
Update USER_GUIDE.md and Python imports to use the latest PARAM branch
Browse files Browse the repository at this point in the history
  • Loading branch information
TaekyungHeo committed Jul 1, 2024
1 parent b8b2b74 commit 7229f36
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 11 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/end_to_end_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ jobs:
- name: Install PARAM
run: |
git clone https://github.com/facebookresearch/param.git
cd param/train/compute/python/
git checkout c83ce8429110a86549c40fec5a01acbd9fbd54a4
git checkout 884a1f0154a16e2c170e456f8027f2646c9108ae
cd param/et_replay
sed -i '/param_bench/d' pyproject.toml
pip install .
- name: Test chakra_trace_link Without Arguments
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/python_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ jobs:
- name: Install PARAM
run: |
git clone https://github.com/facebookresearch/param.git
cd param/train/compute/python/
git checkout c83ce8429110a86549c40fec5a01acbd9fbd54a4
git checkout 884a1f0154a16e2c170e456f8027f2646c9108ae
cd param/et_replay
sed -i '/param_bench/d' pyproject.toml
pip install .
- name: Install Dependencies
Expand Down
5 changes: 3 additions & 2 deletions USER_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@ Installing PARAM is necessary for Chakra to function properly as it imports esse

```bash
$ git clone [email protected]:facebookresearch/param.git
$ cd param/train/compute/python/
$ git checkout c83ce8429110a86549c40fec5a01acbd9fbd54a4
$ git checkout 884a1f0154a16e2c170e456f8027f2646c9108ae
$ cd param/et_replay
$ sed -i '' '13d' pyproject.toml
$ pip install .
```

Expand Down
2 changes: 1 addition & 1 deletion src/trace_link/kineto_operator.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Any, Dict, Optional

from param_bench.train.compute.python.tools.execution_trace import Node as PyTorchOperator
from et_replay.lib.execution_trace import Node as PyTorchOperator


class KinetoOperator:
Expand Down
6 changes: 2 additions & 4 deletions src/trace_link/trace_linker.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,12 @@
from concurrent.futures import ThreadPoolExecutor, as_completed
from typing import Dict, List, Optional, Tuple

from param_bench.train.compute.python.tools.execution_trace import (
from et_replay.lib.execution_trace import (
EXECUTION_TRACE_PROCESS_ANNOTATION,
EXECUTION_TRACE_THREAD_ANNOTATION,
)
from param_bench.train.compute.python.tools.execution_trace import (
Node as PyTorchOperator,
)
from param_bench.train.compute.python.tools.utility import (
from et_replay.lib.utils import (
load_execution_trace_file,
read_dictionary_from_json_file,
)
Expand Down

0 comments on commit 7229f36

Please sign in to comment.