Skip to content

Commit

Permalink
fix lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
@rvinaybharadwaj
rvinaybharadwaj committed Sep 5, 2024
1 parent a151e08 commit 6f66943
Show file tree
Hide file tree
Showing 5 changed files with 770 additions and 858 deletions.
254 changes: 125 additions & 129 deletions src/feeder/JSONNode.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,192 +4,188 @@
JSONNode::JSONNode() {}

// JSONNode copy constructor
JSONNode::JSONNode(const JSONNode &t) {
node_id = t.node_id;
node_name = t.node_name;
node_type = t.node_type;
is_cpu_op = t.is_cpu_op;
runtime = t.runtime;
data_deps = t.data_deps;
dep_unresolved_parent_ids_json = t.dep_unresolved_parent_ids_json;
children_vec_json = t.children_vec_json;
children_set_json = t.children_set_json;
/* COMM_SEND_NODE = 5,
COMM_RECV_NODE = 6,
COMM_COLL_NODE = 7 */
if (node_type == 5 || node_type == 6 || node_type == 7) {
tensor_size = t.tensor_size;
comm_type = t.comm_type;
comm_priority = t.comm_priority;
comm_size = t.comm_size;
comm_src = t.comm_src;
comm_dst = t.comm_dst;
comm_tag = t.comm_tag;
}
JSONNode::JSONNode(const JSONNode& t) {
node_id = t.node_id;
node_name = t.node_name;
node_type = t.node_type;
is_cpu_op = t.is_cpu_op;
runtime = t.runtime;
data_deps = t.data_deps;
dep_unresolved_parent_ids_json = t.dep_unresolved_parent_ids_json;
children_vec_json = t.children_vec_json;
children_set_json = t.children_set_json;
/* COMM_SEND_NODE = 5,
COMM_RECV_NODE = 6,
COMM_COLL_NODE = 7 */
if (node_type == 5 || node_type == 6 || node_type == 7) {
tensor_size = t.tensor_size;
comm_type = t.comm_type;
comm_priority = t.comm_priority;
comm_size = t.comm_size;
comm_src = t.comm_src;
comm_dst = t.comm_dst;
comm_tag = t.comm_tag;
}
}

// JSONNode constructor
JSONNode::JSONNode(json data, uint64_t id) {
try {
node_id = data["workload_graph"][id]["Id"];
}
catch (...) {
std::cerr << "node_id not specified in ET" << std::endl;
}
try {
node_name = data["workload_graph"][id]["Name"];
}
catch (...) {
std::cerr << "node_name not specified in ET" << std::endl;
}
try {
node_type = data["workload_graph"][id]["NodeType"];
}
catch (...) {
std::cerr << "node_type not specified in ET" << std::endl;
}
try {
is_cpu_op = data["workload_graph"][id]["is_cpu_op"];
}
catch (...) {
std::cerr << "is_cpu_op not specified in ET" << std::endl;
}
try {
runtime = data["workload_graph"][id]["runtime"];
}
catch (...) {}
try {
data_deps = data["workload_graph"][id]["data_deps"].get<std::vector<uint64_t>>();
}
catch (...) {
std::cerr << "data deps not specified in ET" << std::endl;
}
/* COMM_SEND_NODE = 5,
COMM_RECV_NODE = 6,
COMM_COLL_NODE = 7 */
if (node_type == 5 || node_type == 6 || node_type == 7) {
try {
tensor_size = data["workload_graph"][id]["tensor_size"];
}
catch (...) {}
try {
comm_type = data["workload_graph"][id]["comm_type"];
}
catch (...) {}
try {
comm_priority = data["workload_graph"][id]["comm_priority"];
}
catch (...) {
comm_priority = 0; // Protobuf defaults to 0
}
try {
comm_size = data["workload_graph"][id]["comm_size"];
}
catch (...) {}
try {
comm_src = data["workload_graph"][id]["comm_src"];
}
catch (...) {}
try {
comm_dst = data["workload_graph"][id]["comm_dst"];
}
catch (...) {}
try {
comm_tag = data["workload_graph"][id]["comm_tag"];
}
catch (...) {}
}
}
try {
node_id = data["workload_graph"][id]["Id"];
} catch (...) {
std::cerr << "node_id not specified in ET" << std::endl;
}
try {
node_name = data["workload_graph"][id]["Name"];
} catch (...) {
std::cerr << "node_name not specified in ET" << std::endl;
}
try {
node_type = data["workload_graph"][id]["NodeType"];
} catch (...) {
std::cerr << "node_type not specified in ET" << std::endl;
}
try {
is_cpu_op = data["workload_graph"][id]["is_cpu_op"];
} catch (...) {
std::cerr << "is_cpu_op not specified in ET" << std::endl;
}
try {
runtime = data["workload_graph"][id]["runtime"];
} catch (...) {
}
try {
data_deps =
data["workload_graph"][id]["data_deps"].get<std::vector<uint64_t>>();
} catch (...) {
std::cerr << "data deps not specified in ET" << std::endl;
}
/* COMM_SEND_NODE = 5,
COMM_RECV_NODE = 6,
COMM_COLL_NODE = 7 */
if (node_type == 5 || node_type == 6 || node_type == 7) {
try {
tensor_size = data["workload_graph"][id]["tensor_size"];
} catch (...) {
}
try {
comm_type = data["workload_graph"][id]["comm_type"];
} catch (...) {
}
try {
comm_priority = data["workload_graph"][id]["comm_priority"];
} catch (...) {
comm_priority = 0; // Protobuf defaults to 0
}
try {
comm_size = data["workload_graph"][id]["comm_size"];
} catch (...) {
}
try {
comm_src = data["workload_graph"][id]["comm_src"];
} catch (...) {
}
try {
comm_dst = data["workload_graph"][id]["comm_dst"];
} catch (...) {
}
try {
comm_tag = data["workload_graph"][id]["comm_tag"];
} catch (...) {
}
}
}

// Node id
uint64_t JSONNode::id() const{
return node_id;
uint64_t JSONNode::id() const {
return node_id;
}

// Node name
std::string JSONNode::name() const{
return node_name;
std::string JSONNode::name() const {
return node_name;
}

// Node type
int JSONNode::type() const{
return node_type;
int JSONNode::type() const {
return node_type;
}

// Check if CPU OP
bool JSONNode::isCPUOp() const{
return is_cpu_op;
bool JSONNode::isCPUOp() const {
return is_cpu_op;
}

// Runtime
uint64_t JSONNode::getRuntime() const{
return runtime;
uint64_t JSONNode::getRuntime() const {
return runtime;
}

// Num ops
uint64_t JSONNode::getNumOps() const{
return num_ops;
uint64_t JSONNode::getNumOps() const {
return num_ops;
}

// Tensor size
uint64_t JSONNode::getTensorSize() const{
return tensor_size;
uint64_t JSONNode::getTensorSize() const {
return tensor_size;
}

// Comm type
int64_t JSONNode::getCommType() const{
return comm_type;
int64_t JSONNode::getCommType() const {
return comm_type;
}

// Comm priority
uint32_t JSONNode::getCommPriority() const{
return comm_priority;
uint32_t JSONNode::getCommPriority() const {
return comm_priority;
}

// Comm size
uint64_t JSONNode::getCommSize() const{
return comm_size;
uint64_t JSONNode::getCommSize() const {
return comm_size;
}

// Comm src
uint32_t JSONNode::getCommSrc() const{
return comm_src;
uint32_t JSONNode::getCommSrc() const {
return comm_src;
}

// Comm dst
uint32_t JSONNode::getCommDst() const{
return comm_dst;
uint32_t JSONNode::getCommDst() const {
return comm_dst;
}

// Comm tag
uint32_t JSONNode::getCommTag() const{
return comm_tag;
uint32_t JSONNode::getCommTag() const {
return comm_tag;
}

// Dependency unresolved parent IDs
void JSONNode::addDepUnresolvedParentID(uint64_t node_id) {
dep_unresolved_parent_ids_json.emplace_back(node_id);
dep_unresolved_parent_ids_json.emplace_back(node_id);
}

// Get dependency unresolved parent IDs
std::vector<uint64_t> JSONNode::getDepUnresolvedParentIDs() {
return dep_unresolved_parent_ids_json;
return dep_unresolved_parent_ids_json;
}

// Set dependency unresolved parent IDs
void JSONNode::setDepUnresolvedParentIDs(std::vector<uint64_t> const& dep_unresolved_parent_ids) {
dep_unresolved_parent_ids_json = dep_unresolved_parent_ids;
void JSONNode::setDepUnresolvedParentIDs(
std::vector<uint64_t> const& dep_unresolved_parent_ids) {
dep_unresolved_parent_ids_json = dep_unresolved_parent_ids;
}

// Add child
void JSONNode::addChild(JSONNode node) {
// Avoid adding the same child node multiple times
// addChild is called multiple times to resolve dependencies
if (children_set_json.find(node) != children_set_json.end()) {
return;
}
children_vec_json.emplace_back(node);
children_set_json.emplace(node);
// Avoid adding the same child node multiple times
// addChild is called multiple times to resolve dependencies
if (children_set_json.find(node) != children_set_json.end()) {
return;
}
children_vec_json.emplace_back(node);
children_set_json.emplace(node);
}

// Get children vector
Expand Down
Loading

0 comments on commit 6f66943

Please sign in to comment.