Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.toml #830

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

fsschneider
Copy link
Contributor

This PR replaces the current setup.cfg and setup.py with (hopefully) equivalent pyproject.toml.
As described in #803 this is the PEP standard for package setup.
It probably doesn't fully resolve said issue as it also included more proposed changes du the dataset setup.

Note: We plan to move to ruff (replacing isort, pylint and yapf) as well as renaming the package to algoperf. Therefore, the pyproject.toml will change substantially with follow-up PRs.

@IFFranciscoME, I currently can't add you as a reviewer, but I am happy to hear your feedback as well.

@fsschneider fsschneider requested a review from a team as a code owner January 15, 2025 12:12
Copy link

github-actions bot commented Jan 15, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@IFFranciscoME
Copy link

@fsschneider Thanks for the tag and the acknowledgement of the 2 cents of work I've previously added to this engineering topic.

From a quick look, here are some notes

  1. 100% agree in going for pyproject.toml, which I think is a good starter for a folder restructure as well.

  2. Great to see the [project.optional-dependencies]

  3. Perhaps "compiled examples" could be a good thing, i.e. to have an already compiled version of the package, for a "standard" system architecture-config.

I will try to make more free space for this, have had a lot of focus on some PhD work in the past 2 months, but hey, time in one's agenda is not to be founded but has to be created.

This was referenced Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants