[GroMEt] Function Default Missing Values PR #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentraymond-ua
approved these changes
Apr 2, 2024
github-actions bot
added a commit
that referenced
this pull request
Apr 2, 2024
This PR addresses an issue with function calls and default values. If a function call is happening and it contains keyword arguments, the GroMEt FN wouldn't appropriately wire all the ports to the operations that were happening. This has been fixed. ### Summary of Changes - Updated `to_gromet_pass.py` so that it more correctly generates keyword arguments. - Added test script `test_fun_default.py` that ensures consistency for generating keyword arguments. ### Related issues - None Resolves #810 a618df2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with function calls and default values. If a function call is happening and it contains keyword arguments, the GroMEt FN wouldn't appropriately wire all the ports to the operations that were happening. This has been fixed.
Summary of Changes
to_gromet_pass.pyso that it more correctly generates keyword arguments.test_fun_default.pythat ensures consistency for generating keyword arguments.Related issues
Resolves #810