Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Infix Notation Fix and Multiplication Tree Depth Bugfix #872

Merged
merged 7 commits into from
Mar 27, 2024

Conversation

Free-Quarks
Copy link
Collaborator

@Free-Quarks Free-Quarks commented Mar 27, 2024

Summary of Changes

  • Fixes an issue where when a binary multiplication tree got too deep, we failed to fully flatten it, leading to Petrinet parsing errors.
  • Fixes an error with infix expressions, so should make it so if a transition has division in it, the infix expression will properly show that as well, instead of * like it was showing before.

Related issues

Resolves #868 #871 #403

@github-actions github-actions bot added MORAE lang/Rust Used for work related to Rust labels Mar 27, 2024
@Free-Quarks Free-Quarks changed the title Infix Division and Multiplication Tree Depth Bugfixes Full Infix Notation Fix and Multiplication Tree Depth Bugfix Mar 27, 2024
@Free-Quarks Free-Quarks merged commit 3c957fe into main Mar 27, 2024
7 checks passed
@Free-Quarks Free-Quarks deleted the lieffers/eval-fixes2 branch March 27, 2024 23:54
github-actions bot added a commit that referenced this pull request Mar 28, 2024
## Summary of Changes
- Fixes an issue where when a binary multiplication tree got too deep,
we failed to fully flatten it, leading to Petrinet parsing errors.
- Fixes an error with infix expressions, so should make it so if a
transition has division in it, the infix expression will properly show
that as well, instead of `*` like it was showing before.

### Related issues

Resolves #868 #871 #403

---------

Co-authored-by: Justin <[email protected]> 3c957fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix lang/Rust Used for work related to Rust MORAE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MORAE] Infix expressions bug for division
1 participant