MATLAB to GroMEt testing #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 18, 2024 08:24
…stier/gromet_debug
jastier
added
tests
github-actions
bot
removed
the
tests
|
Main description edited to include related and partially resolved issues. |
titomeister
approved these changes
Jan 29, 2024
|
@titomeister , can you please try resolving these conflicts so that we can merge this PR? |
|
@titomeister , it looks like the tests are now failing. These were working as of 9933c53. Can you please take another look? |
|
@myedibleenso I'm looking. For some reason a bunch of places just have outdated pieces of code. I've tried merging what's in main but it doesn't seem to fix it. Trying to fix manually now. |
github-actions bot
added a commit
that referenced
this pull request
Feb 12, 2024
## MATLAB to GroMEt testing This PR adds GroMEt translation to all pytest cases in the Tree-Sitter MATLAB translator. This was done as part of the fix for a bug that was happening when generating Model Coverage Reports. The CAST to GroMEt converter was reporting correctly that the "list" type is not supported, switching to the corresponding enumeration fixed that issue. ## Relavant Features: - Each pytest case now includes GroMEt translation. - Got rid of some outdated static method typing calls. - `LiteralValue `data types are now CAST enumerations instead of hard-coded strings. - Removed the handler for `Range `Tree-sitter syntax nodes, these nodes are managed by iterator routines - Turned off the pytest series related to loops temporarily Related to issue #725 Partially resolves issue #764 --------- Co-authored-by: Joseph Astier <[email protected]> Co-authored-by: Tito Ferra <[email protected]> Co-authored-by: titomeister <[email protected]> 159d40e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MATLAB to GroMEt testing
This PR adds GroMEt translation to all pytest cases in the Tree-Sitter MATLAB translator. This was done as part of the fix for a bug that was happening when generating Model Coverage Reports. The CAST to GroMEt converter was reporting correctly that the "list" type is not supported, switching to the corresponding enumeration fixed that issue.
Relavant Features:
LiteralValuedata types are now CAST enumerations instead of hard-coded strings.RangeTree-sitter syntax nodes, these nodes are managed by iterator routinesRelated to issue #725
Partially resolves issue #764