[code2fn] Adds debug messages when ingesting unsupported files #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kema_py_updates
vincentraymond-ua
changed the title
github-actions bot
added a commit
that referenced
this pull request
Oct 4, 2023
## Debug messages when trying to ingest unsupported files Adds debug messages when the user tries to ingest an unsupported file type through the code2fn endpoints. The messages are passed through the Gromet as a Debug Metadata type in the top level `GrometFNModuleCollection.metadata_collection` field. ### Debug message types - WARNING: In the case there are mixed supported/unsupported files in a system. - ERROR: In the case there are are only unsupported files in a system. ### Testing - Adds two additional tests, `test_no_supported_files` and `test_mixed_supported_files` - Re-enables skema_py endpoint tests ## Updates to Gromet FN schema Adds a metadata_collection field to GrometFNModuleCollection. This change is still considered part of Gromet FN 0.1.8, so the version number will not be bumped. Resolves #401 282f19a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug messages when trying to ingest unsupported files
Adds debug messages when the user tries to ingest an unsupported file type through the code2fn endpoints. The messages are passed through the Gromet as a Debug Metadata type in the top level
GrometFNModuleCollection.metadata_collectionfield.Debug message types
Testing
test_no_supported_filesandtest_mixed_supported_filesUpdates to Gromet FN schema
Adds a metadata_collection field to GrometFNModuleCollection. This change is still considered part of Gromet FN 0.1.8, so the version number will not be bumped.
Resolves #401