Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on handling math expressions — Differential, gradient, dot #539

Merged
merged 74 commits into from
Oct 2, 2023

Conversation

deepsana
Copy link
Contributor

@deepsana deepsana commented Oct 2, 2023

  • A working example of one-dimensional Energy Balance Model (EBM).
  • MathExpression enum now takes a "Differential" variant consisting of both "Derivative" and "Ci" and it can parse differential being in both LHS and RHS of the function.
  • Incorporated handling of gradients and dot operators.

@myedibleenso
Copy link
Collaborator

It looks as if one of the Rust tests related to mathml is failing: https://github.com/ml4ai/skema/actions/runs/6383918720/job/17325501765#step:14:587

Copy link
Collaborator

@Free-Quarks Free-Quarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Free-Quarks Free-Quarks merged commit 1dfcf02 into main Oct 2, 2023
8 checks passed
@Free-Quarks Free-Quarks deleted the dshahi-expression branch October 2, 2023 20:58
github-actions bot added a commit that referenced this pull request Oct 2, 2023
)

- A working example of one-dimensional Energy Balance Model (EBM).
- MathExpression enum now takes a "Differential" variant consisting of
both "Derivative" and "Ci" and it can parse differential being in both
LHS and RHS of the function.
- Incorporated handling of gradients and dot operators.

---------

Co-authored-by: Deepsana Shahi <[email protected]>
Co-authored-by: Gus Hahn-Powell <[email protected]> 1dfcf02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants