Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MATLAB CAST to GroMEt bugs #764

Open
jastier opened this issue Jan 20, 2024 · 0 comments
Open

MATLAB CAST to GroMEt bugs #764

jastier opened this issue Jan 20, 2024 · 0 comments
Assignees
@jastier
Labels
bug Something isn't working lang/MATLAB Used for work related to MATLAB frontend

Comments

@jastier
Copy link
Contributor

jastier commented Jan 20, 2024 •
edited
Loading

MATLAB CAST to GroMEt bugs

The following errors are being reported when converting SV2AIR3-Waterloo-MATLAB source files into GroMEt during Model Coverage Reporting. These errors are due to not-yet-completed handling routines in skema/program_analysis/CAST/matlab/matlab_to_cast.py

AttributeError: 'Var' object has no attribute 'id'

Seen when processing:

  • get_beta.m
  • get_vaccine_rate.m
  • svair.m
  • svir.m

Unrecognized node type: <class 'int'>

Seen when processing:

  • plot_data.m
  • shade.m

Processing exceeded timeout (10s)

Seen when processing:

  • voc2_driver.m
@jastier jastier added bug Something isn't working lang/MATLAB Used for work related to MATLAB frontend labels Jan 20, 2024
@github-project-automation github-project-automation bot moved this to TODO in skema Jan 20, 2024
@jastier jastier self-assigned this Jan 20, 2024
@jastier jastier mentioned this issue Jan 20, 2024
Merged
titomeister added a commit that referenced this issue Feb 12, 2024
@jastier @titomeister
MATLAB to GroMEt testing (#765)
159d40e 
## MATLAB to GroMEt testing
This PR adds GroMEt translation to all pytest cases in the Tree-Sitter
MATLAB translator. This was done as part of the fix for a bug that was
happening when generating Model Coverage Reports. The CAST to GroMEt
converter was reporting correctly that the "list" type is not supported,
switching to the corresponding enumeration fixed that issue.

## Relavant Features:
- Each pytest case now includes GroMEt translation.
- Got rid of some outdated static method typing calls.
- `LiteralValue `data types are now CAST enumerations instead of
hard-coded strings.
- Removed the handler for `Range `Tree-sitter syntax nodes, these nodes
are managed by iterator routines
- Turned off the pytest series related to loops temporarily

Related to issue #725 
Partially resolves issue #764

---------

Co-authored-by: Joseph Astier <[email protected]>
Co-authored-by: Tito Ferra <[email protected]>
Co-authored-by: titomeister <[email protected]>
github-actions bot added a commit that referenced this issue Feb 12, 2024
@github-actions @titomeister
MATLAB to GroMEt testing (#765)
5a93e17 
## MATLAB to GroMEt testing
This PR adds GroMEt translation to all pytest cases in the Tree-Sitter
MATLAB translator. This was done as part of the fix for a bug that was
happening when generating Model Coverage Reports. The CAST to GroMEt
converter was reporting correctly that the "list" type is not supported,
switching to the corresponding enumeration fixed that issue.

## Relavant Features:
- Each pytest case now includes GroMEt translation.
- Got rid of some outdated static method typing calls.
- `LiteralValue `data types are now CAST enumerations instead of
hard-coded strings.
- Removed the handler for `Range `Tree-sitter syntax nodes, these nodes
are managed by iterator routines
- Turned off the pytest series related to loops temporarily

Related to issue #725
Partially resolves issue #764

---------

Co-authored-by: Joseph Astier <[email protected]>
Co-authored-by: Tito Ferra <[email protected]>
Co-authored-by: titomeister <[email protected]> 159d40e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jastier jastier

Labels
bug Something isn't working lang/MATLAB Used for work related to MATLAB frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jastier