Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SKEMA_GRAPH_DB_HOST and SKEMA_GRAPH_DB_PORT variables #44

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

vincentraymond-ua
Copy link
Contributor

Adds SKEMA_GRAPH_DB_HOST and SKEMA_GRAPH_DB_PORT to end-to-end docker-compose.yml

Copy link
Contributor

@Free-Quarks Free-Quarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vincentraymond-ua vincentraymond-ua marked this pull request as ready for review November 15, 2023 19:14
@vincentraymond-ua vincentraymond-ua merged commit ae60fba into main Nov 15, 2023
1 check passed
vincentraymond-ua added a commit to ml4ai/skema that referenced this pull request Nov 15, 2023
… variables (#650)

## Adding environmental variables
Adds the `SKEMA_GRAPH_DB_HOST` and `SKEMA_GRAPH_DB_PORT` environmental
variables to skema/rest.

Updates the execution engine to use these values to connect to Memgraph.

See the corresponding PR to set these values in the ASKEM-TA1-DockerVM
repo:
ml4ai/ASKEM-TA1-DockerVM#44

---------

Co-authored-by: Justin <[email protected]>
Co-authored-by: Gus Hahn-Powell <[email protected]>
github-actions bot added a commit to ml4ai/skema that referenced this pull request Nov 15, 2023
… variables (#650)

## Adding environmental variables
Adds the `SKEMA_GRAPH_DB_HOST` and `SKEMA_GRAPH_DB_PORT` environmental
variables to skema/rest.

Updates the execution engine to use these values to connect to Memgraph.

See the corresponding PR to set these values in the ASKEM-TA1-DockerVM
repo:
ml4ai/ASKEM-TA1-DockerVM#44

---------

Co-authored-by: Justin <[email protected]>
Co-authored-by: Gus Hahn-Powell <[email protected]> d5aecfd
@myedibleenso
Copy link
Contributor

NOTE: while adding this shouldn't break anything, our ee endpoint that relies on this isn't yet compatible (https://mlbayes.slack.com/archives/C0660LJTKFE/p1700095594102499).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants