Update baseURL #245
Closed
Update baseURL #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking into the failed checks, absolutely a noob at this, but trying to resolve & learn. if resolve will close this commit and re-commit with solution. |
|
There are also some related data structure changes that I'm noticing after changing the URL per your changes. For example, using the example from the README: various properties of the E.g. Perhaps some of those changes are related to the failing tests? I have not investigated further to confirm if that's the issue. |
|
That's a nice spot, I'll investigate that structure further this evening. |
|
baseURL is used in more locations that what this pull request commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that for the 2024 season the base URL has changed.
This pull request would update the base URL.
I believe this would also close issue #244.