Merge pull request #229 from mkreiser/team-name-update

Update Team object with improved team name mapping
mkreiser · Oct 21, 2023 · 5bd6c09 · 5bd6c09
2 parents c6d4ee9 + 0196a66
commit 5bd6c09
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 22 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "espn-fantasy-football-api",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "A Javascript API to connect to ESPN's fantasy football API",
   "main": "web.js",
   "files": [

diff --git a/src/team/team.js b/src/team/team.js
@@ -85,10 +85,7 @@ class Team extends BaseCacheableObject {
   static responseMap = {
     id: 'id',
     abbreviation: 'abbrev',
-    name: {
-      key: 'location',
-      manualParse: (responseData, data) => `${_.trim(data.location)} ${_.trim(data.nickname)}`
-    },
+    name: 'name',
     logoURL: 'logo',
     wavierRank: 'wavierRank',
 

diff --git a/src/team/team.test.js b/src/team/team.test.js
@@ -42,21 +42,6 @@ describe('Team', () => {
   describe('responseMap', () => {
     const buildTeam = (data, options) => Team.buildFromServer(data, options);
 
-    describe('name', () => {
-      describe('manualParse', () => {
-        test('interpolates location and nickname into a single string', () => {
-          const data = {
-            location: ' First ',
-            nickname: ' Last ',
-            name: 'This is not used'
-          };
-          const team = buildTeam(data);
-
-          expect(team.name).toBe(`${_.trim(data.location)} ${_.trim(data.nickname)}`);
-        });
-      });
-    });
-
     describe('roster', () => {
       describe('manualParse', () => {
         test('returns an array of players', () => {