Reduce SettingsScreen duplication #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgoebel
force-pushed
the
reduce-duplication
branch
from
502c01e to
f9a9876
Compare
|
Yeah, I like this implementation. Should make the two variants easier to maintain 👍 |
Instead of duplicating the entire screen across flavors, only duplicate the toggle implementations.
thgoebel
force-pushed
the
reduce-duplication
branch
from
f9a9876 to
6d78f82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of duplicating the entire screen across flavors, only duplicate the toggle implementations.
Inspired by #465 (comment).
Depends on #465, I can rebase this once that is merged.