Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade qm-dsp from 1.7.1 to 1.8.0 #3910

Closed
wants to merge 1 commit into from
Closed

Upgrade qm-dsp from 1.7.1 to 1.8.0 #3910

wants to merge 1 commit into from

Conversation

uklotzde
Copy link
Contributor

No changes for us, just a formal update.

  • Remove obsolete patches
  • Delete unused thread sources

- Remove obsolete patches
- Delete unused thread sources
@uklotzde uklotzde added the build label May 25, 2021
@uklotzde uklotzde added this to the 2.3.0 milestone May 25, 2021
@uklotzde uklotzde requested a review from daschuer May 25, 2021 16:21
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was worried updating to a new major version so short before the release, but it looks like there are only very few changes. Maybe it's okay in this case.

@uklotzde
Copy link
Contributor Author

I was worried updating to a new major version so short before the release, but it looks like there are only very few changes. Maybe it's okay in this case.

No source code changes otherwise, they only applied @daschuer's pending patches.

@daschuer
Copy link
Member

It looks like this reverts the patches.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to revert the part with the patches.

@daschuer
Copy link
Member

The PR is still open: c4dm/qm-dsp#3

@uklotzde
Copy link
Contributor Author

Did I get the changelog wrong?

QM Vamp Plugins v1.8 (January 2020)

  • Fix incorrect chromagram tuning in key detector, improving
    key detector output (thanks to Daniel Schürmann)
  • Add Merged Key Strength Plot output to key detector
  • Fix incorrect time alignment of tonal-change plugin outputs

Sorry for the noise. I guess I got confused by all this patching.

@uklotzde uklotzde closed this May 25, 2021
@uklotzde uklotzde deleted the qm-dsp branch June 4, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants