Library menu: change "Engine DJ Prime" to "Engine DJ"

[audministrator]

Changed Engine Prime to Endgine DJ

[ronso0]

Let's add a comment for translators that 'Engine DJ' is a brand / name and should not be translated.
The syntax is //: hint text and that goes one the line above the tr strings, so here it'd be
//: "Engine DJ" must not be translated

[ronso0]

If this change is okay (@mr-smidge ?), there are other user-visible strings that need to be changed for consistency (and maybe also code comments?).
See https://github.com/search?q=repo%3Amixxxdj%2Fmixxx%20%22engine+prime%22&type=code

[audministrator]

Corected labels for concistency

[ronso0]

Hmmno.. did you forget to push?

[mr-smidge]

This change looks good 👍 - Denon now use "Engine DJ" as the all-encompassing term, covering things like Engine OS (the firmware that runs on hardware players) and Engine Desktop (the software preparation application).

[audministrator]

Hi Guys,

To make it not that confusing .... I did not use ENGINE DJ but eventually changed it to ENGINE OS ?
Based on the input from @Ronso 's instruction on how to get started in GitHub

But now that I know how to make a PR in GitHub.
I can rename it again to ENGINE DJ if you guys feel this is a better description ...
No problem on my side to do it just let me know ...

[ronso0]

You make it confusing : )
The current changes(Engine Prime -> Engine DJ) have been approved by @mr-smidge.

All that should be done now is add the translator hint, and update the other occurences of "Engine Prime", too.
I.e. only the tr strings in src/ directory and maybe the comments. But NOT CMakeLists.txt or changelog.md !

[audministrator]

Don't mind how it turns out at the end ...
Whether it is ENGINE DJ or ENGINE OS, as long as it is not ENGINE PRIME ;-)

[mr-smidge]

Don't mind how it turns out at the end ... Whether it is ENGINE DJ or ENGINE OS, as long as it is not ENGINE PRIME ;-)

My suggestion would be to stick with "Engine DJ" 😄.

Agree with @ronso0 to do the translator hint.

[ronso0]

Okay, so what about the other changes #14248 (comment) @audministrator ?
Currently only WMainMenubar has been changed. You mentioned you "Corected labels for concistency", do you have any local changes you didn't push, yet?

[audministrator]

@mr-smidge "My suggestion would be to stick with "Engine DJ"

Sure no problem to modify it all again to Engine DJ. It will be a good practivce for me to actively use GitHuib :-)

@Ronso Can you tell me if I can make the change in the branch again ? Or should I start all over creating a new branch ?
Next this will push all changes made so far...

[audministrator]

@Ronso

Changed all labels and comments in the code from "Engine OS" to "Engine DJ" as preferred by mr-smidge.

How can I apply the changes in current branch ? should I do something or are the changes automatically available in the current PR ?

[ronso0]

This PR conatins only changes in WMainMenubar, that's why I asked if you have local uncommited changes.
If you expect more changes, something went wrong.

The merge was not necessary btw, we don't need up-to-date 2.5 for this tr changes.

[ronso0]

Looks good, thank you!

Please also add the translator hint everywhere you touched a tr string, see https://github.com/mixxxdj/mixxx/pull/14248/files#r1931116776

When you're done I'll squash all commits.

[audministrator]

Added //: "Engine DJ" must not be translated in all files and commit is done

[ronso0]

Thank you, but as I wrote: the translator hint only needs to be added where tr strings are touched (tr("some text")).
qDebug/qWarning and code comments are not tranlsated.

I'll fixup, squash all comits and force-push later on.

[audministrator]

Sorry learning every day ;-)
Now I see what you meant with 'tr' string ...

Thanks

[acolombier]

Is the & expected there?

[ronso0]

& marks the letter that is used for the mnemonic / keyboard shortcut.
It's been there before, so why remove it?

Though we may add a translator hint for those, too.
Will do that once I clean up this branch in the next days.

[ronso0]

Na, I think I won't. let's add that when we notice issues with that (and we haven't seen any until now AFAIR)

[ronso0]

Squashed and cleaned up.
Should be ready, please check!