Preferences Effects: left/right key in effect lists trigger hide/unhide

[ronso0]

Followup for #13329
Fixes #10580

Or should this rather be Alt + Left/Right, like the track move hotkeys?

[ronso0]

TODO
mention the keys in the description above the list views. This will invalidate the existing translations though..
As a workaround I may grab the tr string from the ui file and append the new hint in the cpp.
When merging to main we may then either update the string in the ui file or move it to the cpp (would allow to painlessly append more info in the future / point releases).

[daschuer]

It works, however it does not feel right, that the opposite direction works as well. Using the plain cursor keys works for me without Alt.
What do you think?

[ronso0]

Ah okay, so that Right works only in the left list, and vice versa.

I'll add that constraint.

[ronso0]

I just thought that it might be expected Left Right move focus, not items. Though focus is usually moved with Tab key, but Left/Right seem to work, too, in button rows at least.

And we have the Alt+key combos to move tracks in playlists (like moving lines in text editors), but there we don't have an equivalent for Left/Right.

So to fully fix #10580 we probably need all Alt combos, Up, down, left, right, home, end. Should be rather easy for single-selection.

[daschuer]

Initial expectation was to change to the right window with tab and back with shif+ tab.
Selecting and moving with > key works greate, even as a mouse user. It was just surprising for me that the opposite direction works as well. It feels more like UnDo. Hoverver I have no idea how to implement undo reasonable. Because for bulk action, moving the focus to the next item in the same box is just right. (This is no feature request)

[ronso0]

Initial expectation was to change to the right window with tab and back with shif+ tab.

Ah okay, so we simply change the tab order:
Visible -> Hidden -> Hide -> Unhide

[ronso0]

About Undo:
impIementing real Undo (view-indpendent hotkey like Ctrl+Z) is a bit over the top here of course.
But maybe we can auto-select the last moved item when switching to the view it has been moved to (with Tab). This would auto-scroll but that would be an okayish tradeoff IMO.

[daschuer]

If you like to go that route and it feels natural, fine.
I just don't want to impose extra work in you.

[ronso0]

I'll prevent Left/Right to right & left view and try the other tab order, and yes, if it feels good I'll do it here, otherwise.. "another time".