Smarties (or SmartList or SmartCrate or QueryCrate or QueryList or ...) open for feedback.

[Eve00000]

Smarties

• save lineditsearch to new smarties

some remarks:

• I read #5575 carefully and tried to follow some ideas from that conversation.

• smarties are crates with other capabilities : No autoDJcrate, no adding tracks, no export (make crate of the smarties)...

• smarties can be 'live' and 'cached' : when the smarties are locked they are cached, else the search is executed when selected (but this goes fast, I'm testing with 13000 tracks table in Virtual Machine, it's just a wink). Cached = tracks in smarties_tracks
  -> when title / name of track is changed and the track is no longer conform with the condition the track continues to stay in the smarties until the smarties is unlocked.

• in querysearch ienter your seartch, push the white square and your search becomes a a smarties.

• click with right mousebutton on a smarties -> edit -> 12 conditions, all track fields with an operator and an value-input
  -> Smarties are SMART
  all meaningful fields of the library can be selected, with matching operators.

• it's possible to use a crate / playlist or historylist in a condition (dropdown)

• each condition needs to end with AND / OR vombined with ( )

• the last condition needs to end with ) END.

• conditions can be switched moved up / down / inserted / deleted. only 12 conditions possible.

• with apply the query is shown as it would be executed

• before are smarties query is saved it's checked -> green rectanhle ok, red = problem

• smarties are updated while updating the conditions -> apply

• I added the 'grouped' logic as in 'grouped crates"

please test and send me feedback

NOTE: there are still a lot of 'leftovers' from conversion of crates to smarties, things that might be used in the future (I'm still in dubio).

20241026.Eve.Mixxx.Smarties.mp4

20241026.Eve.Mixxx.Smarties.mp4

Added (2025/02/01) :
"track" - "is a member of"/"is not a member of" - "all playlists"/"all crates"/"all historylists"

[Eve00000]

thank you, I wil check it out profoundly

[Eve00000]

I updated the conversion from search -> smarties:

• symbols = and ~ are removed in the conversion, if a "-" is discovered in the string than the input is converted to a 'between-condition',
• more sofisticated <> conversion to 'smaller than' / 'greater than' for numeric values and 'before' / 'after' for datevalues
• added the 2-view-logic: Grouped and Non-grouped now possible at the same time, + replace logic -> only grouped, I was missing this and already updated grouped crates.
• if grouped is shown + replaces non-grouped -> added logic so search adds smarties to grouped, else to non grouped
• corrected an occuring fatal error.

[Eve00000]

@ronso0 As a draft can't be used to merge and a draft does not create builds I changed the status again.

[acolombier]

As a draft can't be used to merge

I'm not sure what you mean by that. The point of making a PR a draft is to signal to other contributor that this PR is not yet ready for review, and eventually merge. Once your PR reach maturity (the code reach a certain quality, some testing is provided and/or all the CI checks are passing), you may mark the PR as ready, so the core team knows when to start focusing on getting work merged

draft does not create builds

Drafts do create builds

A common reason for the build not to start is usually conflicts, preventing the creation of a "merge branch", necessary to run to actions, which appears to be the case on your branch.

I'm moving your branch back to draft. Once the PR has reached the maturity criteria mentionned above, feel free to mark it ready so the team can start the review process and merge. Please don't do it beofre as this could lead to unwanted notification spam, or unneded effort on reviewing not ready work.

Also, am I correct in assuming that this is superseeding the PR #13978? If so, could we close it?

Am I correct in assuming that

[Eve00000]

Hi, as a draft people will not try it, it needs some review.
Strange: as a draft th Ci/ Clazt etc didn't start, changind the status started it right away, creating the builds as well.
This is something different then #13978, grouped crates (and upcomming grouped playlists) = logic to group crates, that logic is also used / transposed to use in Smarties / Smartlists / Smartcrates.
So you're wrong ;-)
Once the grouping-logic would be reviewed and accepted I can transpose it to the other lists-structure, at the moment I created a pr for each list-type.

[Eve00000]

if draft means 'no review request ' than this is certainly not a draft.

[acolombier]

as a draft people will not try it

That's not quite right, people will try even draft PR. I have many draft PRs that still are getting tested. It mainly boils down to interest, which is unrelated to PR status.

it needs some review.

if draft means 'no review request ' than this is certainly not a draft.

I think there is confusion here - a review in the context of PR means a reviewal of the code (the implementation details, the design, the style...). It also include testing but isn't strictly reserved to it, meaning that making a PR ready just to get testing is not really respectful of the other contributor's time.

I think you've done the right think by calling for feedback on Zulip (and potentially somewhere else), but as they say in English "you can lead a horse to water, but you can't make him drink"

When it comes to review readiness, note that contributors will usually prefer something smaller (see the stem feature or the rendergraph, which was delivered as multiple small PR). It's not easy to motivate core members to review a 15k lines of C++ ;)

So you're wrong ;-)

Ah yeah, of course. Now that you are saying it, I realise it was already clear to me. Sorry for the noise on that one!

[ronso0]

Strange: as a draft th Ci/ Clazt etc didn't start, changind the status started it right away, creating the builds as well.

I saw that too once or twice. Guess it's Github bug because lately it just worked for my draft PRs.

[acolombier]

Note that Github Actions have been quite unstable since the beginning of the year (see status page and history) so definitely could be that! Remember that actions were built after the Github acquisition by Microsoft, so it is expected to be buggy and unstable ;)