Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted fix for CI error in #826 #829

Closed

Conversation

ddalcino
Copy link
Contributor

@ddalcino ddalcino commented Oct 6, 2024

No description provided.

@jdpurcell
Copy link
Contributor

I reported a similar issue with win64_msvc2022_arm64_cross_compiled. Not sure if it's closely enough related to warrant being in the same PR, but I'd imagine the fix is somewhat similar, i.e. adding another special case in get_arch_dir_name.

         elif arch.startswith("win"):
             m = re.match(r"win\d{2}_(?P<msvc>msvc\d{4})_(?P<winrt>winrt_x\d{2})", arch)
             if m:
                 return f"{m.group('winrt')}_{m.group('msvc')}"
+            elif arch.endswith("_cross_compiled"):
+                return arch[6:-15]
             else:
                 return arch[6:]

Like these two new lines maybe?

@ddalcino
Copy link
Contributor Author

ddalcino commented Oct 9, 2024

I reported a similar issue with win64_msvc2022_arm64_cross_compiled. Not sure if it's closely enough related to warrant being in the same PR, but I'd imagine the fix is somewhat similar, i.e. adding another special case in get_arch_dir_name.

You are correct; this is something that does need to change. Until today, I was not aware that win64_msvc2022_arm64_cross_compiled was a valid architecture, but here it is:

$ python -m aqt list-qt windows desktop --arch 6.8.0
win64_llvm_mingw win64_mingw win64_msvc2022_64 win64_msvc2022_arm64_cross_compiled

In any case, I think this is outside the scope of my PR. This PR is just for fixing an error in CI; I don't want to get into supporting new architectures here.

@ddalcino ddalcino changed the title Attempted fix for error in #826 Attempted fix for CI error in #826 Oct 9, 2024
@ddalcino ddalcino closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants