fix: entropy plugin exec and remove legacy plugin handling #576
+135
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
added
type: bug
|
I am starting to review this right now! It seems like |
j-lanson
force-pushed
the
jlanson/entropy-plugin-fix
branch
from
a2a8fe9
to
824d06d
Compare
@patrickjcasey Good catch, I've updated the file |
|
I am seeing this error when running this branch on the hipcheck repo with the default policy file
It seems that |
As per the PR message, this branch needs the git parser fixes Andrew was working on. Let me rebase off of main now that those fixes are merged. |
j-lanson
force-pushed
the
jlanson/entropy-plugin-fix
branch
from
824d06d
to
2733da7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #559 .
NOTE: this should be merged only after #574 and #570 have been resolved.
Updates
entropyplugin to run smoothly, and also rips out theMITRE_LEGACY_PLUGINSinfrastructure from Hipcheck core, as after this there are no more legacy plugin implementations.Also replaces a lot of
println/eprintlncalls withlog::{warn, error, trace, debug}