Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moved dummy plugins into test-plugins folder #573

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

patrickjcasey
Copy link
Contributor

This branch moves plugin/dummy-* to test-plugins

hc plugin still works with these changes

resolves #569

@patrickjcasey patrickjcasey added this to the 3.8.0 milestone Nov 5, 2024
@patrickjcasey patrickjcasey linked an issue Nov 5, 2024 that may be closed by this pull request
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just requesting additional changes not part of original issue.

Cargo.toml Outdated Show resolved Hide resolved
@patrickjcasey patrickjcasey force-pushed the patrickjcasey/move-dummy-plugins branch from 1afaf55 to 8ee18c1 Compare November 5, 2024 16:42
@patrickjcasey
Copy link
Contributor Author

Removed the non-sdk dummy plugins and removed the -sdk suffix from the sdk-compatible plugins and removed the --sdk flag from hc plugin

Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@j-lanson j-lanson merged commit 2048ec4 into main Nov 5, 2024
9 checks passed
@patrickjcasey patrickjcasey deleted the patrickjcasey/move-dummy-plugins branch November 5, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move dummy plugins to a test dir
2 participants