You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
@kprotty I hate introducing a UAF in real code but this fixes our tests. Given this only happens in deinit which generally only happens on process exit, I'm okay with this until I can dig in and see how to fix this more robustly. Sorry!
6afcde9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kprotty I hate introducing a UAF in real code but this fixes our tests. Given this only happens in
deinit
which generally only happens on process exit, I'm okay with this until I can dig in and see how to fix this more robustly. Sorry!