This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Implements #30, a way to pass --deep flag to codesign tool #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind publishing this in Homebrew? |
Me? I'm just contributing a PR. I presume your question is directed to the repo owner @mitchellh? |
|
The repo hasn't been touched in two years :) |
umbynos
added a commit
to arduino/imgtool-packing
that referenced
this pull request
May 12, 2022
…n_support) to use deep notarization, since this is not yet merged mitchellh/gon#42
umbynos
added a commit
to arduino/imgtool-packing
that referenced
this pull request
May 12, 2022
…n_support) to use deep notarization, since this is not yet merged mitchellh/gon#42
umbynos
added a commit
to arduino/imgtool-packing
that referenced
this pull request
May 12, 2022
…n_support) to use deep notarization, since this is not yet merged mitchellh/gon#42
umbynos
added a commit
to arduino/imgtool-packing
that referenced
this pull request
May 12, 2022
…n_support) to use deep notarization, since this is not yet merged mitchellh/gon#42
umbynos
added a commit
to arduino/imgtool-packing
that referenced
this pull request
May 12, 2022
…deep_sign_support) to use deep notarization, since this is not yet merged mitchellh/gon#42" This reverts commit 5808d20.
|
There have been some releases of this tool more recently than this, is this going to be considered @mitchellh ? |
|
Can we git this merged and released on Homebrew? |
umbynos
added a commit
to arduino/arduino-create-agent
that referenced
this pull request
Nov 7, 2022
…n_support) to use deep notarization, since this is not yet merged mitchellh/gon#42
umbynos
added a commit
to arduino/arduino-create-agent
that referenced
this pull request
Nov 21, 2022
…) to use deep notarization, since this is not yet merged mitchellh/gon#42
umbynos
added a commit
to arduino/arduino-create-agent
that referenced
this pull request
Nov 21, 2022
…) to use deep notarization, since this is not yet merged mitchellh/gon#42
SubJunk
added a commit
to UniversalMediaServer/gon
that referenced
this pull request
Nov 26, 2022
umbynos
added a commit
to arduino/arduino-create-agent
that referenced
this pull request
Nov 29, 2022
…) to use deep notarization, since this is not yet merged mitchellh/gon#42
umbynos
added a commit
to arduino/arduino-create-agent
that referenced
this pull request
Nov 29, 2022
* rename release workflow * bump macos runner to macos-12 * bump ubuntu runner to ubuntu 20.04 * add project name env var, even in the `bundle_id` * rework a bit notarization step * move the bundle generation to a dedicated step: This way we can notarize all the bundle and not only the binary. * use the zip notarized file coming from gon, this requires changes in the installer config * use this fork (https://github.com/darkvertex/gon/tree/deep_sign_support) to use deep notarization, since this is not yet merged mitchellh/gon#42 * test (move the config.ini) to see if notarization works * fix zip archive being included in the installer * github is deprecating `set-output commands` https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ * forgot "$", special encoding is not needed anymore after 62f7d9d https://github.com/orgs/community/discussions/35994#discussioncomment-3971397 * fix `unable-to-process-file-command-output-successfully` https://stackoverflow.com/questions/74137120/how-to-fix-or-avoid-error-unable-to-process-file-command-output-successfully
|
@mitchellh hi! 👋 happy new year -- wanna merge this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋 I needed this so I implemented it. 🎩
(Kudos for a solid project layout; the code was easy to follow.)
I think this could help people doing OSX *.app's since those are secretly directories and it's impossible to notorize them without codesigning every file within.
Let me know what you think or if I missed anything. ("Allow edits by maintainers" is enabled so feel free to tweak anything.)
Thanks for making this tool. OSX security is a clusterfuck to wrap your mind around at first and it helps a ton.