-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public API #3
base: master
Are you sure you want to change the base?
Public API #3
Conversation
The hope is that this makes its way into FlightGoggles so that more data can be mined from the simulator. |
Hi @varunagrawal, The private functions that you made public require arguments. (They were written to handle internal computations using intermediate results.) This is inconvenient for public facing functions, which should just use the current vehicle state. Can you tell me a bit more on how you are using these functions? For example, it seems like external use of Ezra |
Hi @eatal. I'm really sorry for the late response. After spending some more time with the code, I have come to understand why some of those functions should and don't need to be exposed. I'll update this PR. |
@eatal one of my primary use-cases was to get the force and torque acting on the quadrotor at any point, since I could compare those forces as ground truth. Do you think there is a clean way to do that? |
This PR puts all functions in the public scope so an end-user can access various properties of the simulator (such as force and torque).