Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public API #3

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

varunagrawal
Copy link

This PR puts all functions in the public scope so an end-user can access various properties of the simulator (such as force and torque).

@varunagrawal
Copy link
Author

The hope is that this makes its way into FlightGoggles so that more data can be mined from the simulator.

@eatal
Copy link
Contributor

eatal commented Oct 21, 2020

Hi @varunagrawal,
Thanks for the pull request. I think it's a good idea to make more vehicle state information available. We can add some new public functions for this.

The private functions that you made public require arguments. (They were written to handle internal computations using intermediate results.) This is inconvenient for public facing functions, which should just use the current vehicle state.

Can you tell me a bit more on how you are using these functions? For example, it seems like external use of getAttitudeDerivative would be better served by the existing public function getVehicleAngularVelocity.

Ezra

@varunagrawal
Copy link
Author

Hi @eatal. I'm really sorry for the late response. After spending some more time with the code, I have come to understand why some of those functions should and don't need to be exposed. I'll update this PR.

@varunagrawal
Copy link
Author

@eatal one of my primary use-cases was to get the force and torque acting on the quadrotor at any point, since I could compare those forces as ground truth. Do you think there is a clean way to do that?

@varunagrawal varunagrawal deleted the feature/improved-api branch February 14, 2024 20:40
@varunagrawal varunagrawal restored the feature/improved-api branch February 14, 2024 20:40
@varunagrawal varunagrawal reopened this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants