Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cstruct #32

Merged
merged 11 commits into from
Aug 5, 2024
Merged

No cstruct #32

merged 11 commits into from
Aug 5, 2024

Conversation

dinosaure
Copy link
Member

On top of #29 (it seems that I don't have to push on the @hannesm repository).

@dinosaure dinosaure mentioned this pull request Jul 22, 2024
@dinosaure dinosaure force-pushed the no-cstruct branch 5 times, most recently from f2246d9 to da63fc1 Compare July 22, 2024 13:47
@dinosaure
Copy link
Member Author

It seems that we have an error on ca-certs on Windows and I suspect x509. I don't have a Windows machine available, but I will look on that as soon as I can.

@hannesm
Copy link
Member

hannesm commented Jul 24, 2024

needs a dune build @fmt, and indeed investigating the windows issue would be great (since that's a showstopper)

@hannesm hannesm force-pushed the no-cstruct branch 2 times, most recently from 66842b6 to 62afc58 Compare August 5, 2024 14:59
@hannesm
Copy link
Member

hannesm commented Aug 5, 2024

rebased & autoformat. I'll take a deeper dive into the issue that is encountered here. sorry for the force-pushes.

@hannesm hannesm merged commit a20aac8 into mirage:main Aug 5, 2024
7 checks passed
hannesm added a commit to hannesm/opam-repository that referenced this pull request Aug 6, 2024
CHANGES:

* Use X509.Certificate.fold_decode_pem, available in x509 1.0.0 (mirage/ca-certs#34 mirage/ca-certs#35 @art-w
  @hannesm)
* Remove usage of cstruct, update to x509 1.0.0 and mirage-crypto 1.0.0 API
  (mirage/ca-certs#32 @dinosaure @hannesm)
* Remove astring dependency (mirage/ca-certs#26 @hannesm)
@dinosaure dinosaure deleted the no-cstruct branch September 3, 2024 14:58
avsm pushed a commit to avsm/opam-repository that referenced this pull request Sep 5, 2024
CHANGES:

* Use X509.Certificate.fold_decode_pem, available in x509 1.0.0 (mirage/ca-certs#34 mirage/ca-certs#35 @art-w
  @hannesm)
* Remove usage of cstruct, update to x509 1.0.0 and mirage-crypto 1.0.0 API
  (mirage/ca-certs#32 @dinosaure @hannesm)
* Remove astring dependency (mirage/ca-certs#26 @hannesm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants