Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port internetnl bit → nibble #4026

Draft
wants to merge 17 commits into
base: feature/nibbles
Choose a base branch
from

Conversation

originalsouth
Copy link
Contributor

Changes

Port internetnl bit → nibble

Issue link

#3808

Demo

N/A

QA notes

N/A


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • [ x] I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@originalsouth
Copy link
Contributor Author

Blocked on #4000 resolution.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
35.3% Coverage on New Code (required ≥ 80%)
17.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@@ -17,7 +17,7 @@ services:
args:
ENVIRONMENT: dev
context: .
command: pytest tests/integration --timeout=300
command: pytest -s tests/integration/test_internetnl_nibble.py --timeout=300
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not what you wanted to commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving it till the draft is completed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: these are branches we pass back and forth a lot so we want to directly in the test we are working on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nibbles Everything nibble related
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

2 participants