-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore missing csp if page is not xss capable #3126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few tiny remark to improve it even more
Co-authored-by: ammar92 <[email protected]>
Lets decide whether we want to tackle the other csp finding in this pr or in another one, and lets also determine the best option! |
We went for the second solution, need to add to release notes that a recalculate bits is needed after upgrading |
…-coordination into ignore-missing-csp
…-coordination into ignore-missing-csp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No remarks
Checklist for QA:
What works:The following scenarios were tested:
The tested scenarios all give the expected output. What doesn't work:n/a Bug or feature?:n/a
|
Changes
We do not create missing CSP findings if the page is not XSS capable. Open for discussion:
For the other findings (misconfigured csp and disallowed domains in csp) we have two options:
Issue link
#1950
Closes #1950
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.