-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation - developer and helper functionality documentation for xtdb-cli tool #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already merged in another PR
This reverts commit dbd523a.
8 tasks
stephanie0x00
changed the title
Documentation - developer documentation for xtdb-cli tool
Documentation - developer and helper functionality documentation for xtdb-cli tool
Jun 5, 2024
ammar92
previously approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor suggestions, but should be ready to merge soon?
Quality Gate passedIssues Measures |
Changes from review. Co-authored-by: ammar92 <[email protected]>
underdarknl
approved these changes
Jun 12, 2024
jpbruinsslot
added a commit
that referenced
this pull request
Jun 17, 2024
* main: (40 commits) Translations update from Hosted Weblate (#3091) feat: 📝 add API titles (#3055) Fixed 2 small mistakes in documentation (#3089) Documentation - developer and helper functionality documentation for xtdb-cli tool (#3023) fix: 🔧 update db normalize setting (#2777) Translations update from Hosted Weblate (#3048) Translations update from Hosted Weblate (#3018) Fix empty consumes of boefjes will trigger tasks in scheduler (#3017) Fixes text in secondary menu on scan profile detail page (#3035) chore: Resolves css-issues found by sonarcloud (#3034) Add raw AuthToken SQL migration (#3009) Translations update from Hosted Weblate (#3012) Rewrite xtdb-cli.py with "click" (#2957) Phase out the Repository model from the KATalogus (#2984) Fix merge conflicts in weblate (#3007) Translations update from Hosted Weblate (#2996) Reports: Fix select all OOIs (#2909) Adding IPv6 support to documentation for Docker setups (#2813) Translations update from Hosted Weblate (#2930) User documentation for reports (#2898) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds :
the help texts to the XTDB cli tool for all commands and optional arguments and a general description for the tool itself. Most of the CLI tool texts were copied and adjusted where necessary based on the XTDB HTTP documentation (https://v1-docs.xtdb.com/clients/1.24.3/http/)
the documentation on how to use the xtdb-cli tool to https://docs.openkat.nl/. It includes a notification that OpenKAT doesn't use vanilla xtdb and provides some examples on how to use the xtdb-cli tool.
Issue link
This PR closes: #2877
Demo
And now also with the helper text for the optional arguments:
Code Checklist
Communication
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.