Fix empty consumes of boefjes will trigger tasks in scheduler #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underdarknl
reviewed
Jun 4, 2024
Checklist for QA:
What works:Seems to work as expected, nothing identified that isn't working. What doesn't work:n/a Bug or feature?:n/a |
|
underdarknl
approved these changes
Jun 6, 2024
jpbruinsslot
added a commit
that referenced
this pull request
Jun 11, 2024
* main: (78 commits) Translations update from Hosted Weblate (#3048) Translations update from Hosted Weblate (#3018) Fix empty consumes of boefjes will trigger tasks in scheduler (#3017) Fixes text in secondary menu on scan profile detail page (#3035) chore: Resolves css-issues found by sonarcloud (#3034) Add raw AuthToken SQL migration (#3009) Translations update from Hosted Weblate (#3012) Rewrite xtdb-cli.py with "click" (#2957) Phase out the Repository model from the KATalogus (#2984) Fix merge conflicts in weblate (#3007) Translations update from Hosted Weblate (#2996) Reports: Fix select all OOIs (#2909) Adding IPv6 support to documentation for Docker setups (#2813) Translations update from Hosted Weblate (#2930) User documentation for reports (#2898) Fix task api status code response for malformed id in the scheduler (#2953) Add drill trace option in dnssec boefje (#2979) Updated packages (#2972) Update granian and remove workaround for fixed bug (#2980) Fix typing in boefjes/normalizers (#2933) ...
jpbruinsslot
added a commit
that referenced
this pull request
Jun 17, 2024
* main: (40 commits) Translations update from Hosted Weblate (#3091) feat: 📝 add API titles (#3055) Fixed 2 small mistakes in documentation (#3089) Documentation - developer and helper functionality documentation for xtdb-cli tool (#3023) fix: 🔧 update db normalize setting (#2777) Translations update from Hosted Weblate (#3048) Translations update from Hosted Weblate (#3018) Fix empty consumes of boefjes will trigger tasks in scheduler (#3017) Fixes text in secondary menu on scan profile detail page (#3035) chore: Resolves css-issues found by sonarcloud (#3034) Add raw AuthToken SQL migration (#3009) Translations update from Hosted Weblate (#3012) Rewrite xtdb-cli.py with "click" (#2957) Phase out the Repository model from the KATalogus (#2984) Fix merge conflicts in weblate (#3007) Translations update from Hosted Weblate (#2996) Reports: Fix select all OOIs (#2909) Adding IPv6 support to documentation for Docker setups (#2813) Translations update from Hosted Weblate (#2930) User documentation for reports (#2898) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When a boefje gets enabled the scheduler will check whether this boefje can run on ooi's that allow this boefje to run on. To do that the scheduler checks what types a boefje can consume. The scheduler will ask octopoes to return those ooi's. When the
consumesfield of a boefje is empty it will ask octopoes to return ooi's and it will do so when an empty list is provided.This PR adds a check before the scheduler will ask octopoes to return ooi's, it will check if the
consumesfield is empty or not and will not request octopoes for ooi's when it is.Issue link
Closes #3015
QA steps
From what I can see it is not possible to set the consumes of a boefje to an empty list from the webapp. In order to make sure that everything should be working as intended, is to enable a boefje and make sure that the types the ooi's consumes, tasks are being created for ooi's of that type.