Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Pydantic v2 #1912

Merged
merged 115 commits into from
Dec 5, 2023
Merged

Upgrade to Pydantic v2 #1912

merged 115 commits into from
Dec 5, 2023

Conversation

ammar92
Copy link
Contributor

@ammar92 ammar92 commented Oct 17, 2023

Changes

This updates the Pydantic package to the latest major version. Please keep in mind that this should be tested properly:

  • It should work on "old" data
  • The OOI creation forms should still work
  • Onboarding flow works as usual
  • OOI detail and listing views work as usual

Issue link

Closes #1841


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Signed-off-by: ammar <[email protected]>
Signed-off-by: ammar <[email protected]>
Signed-off-by: ammar <[email protected]>
Signed-off-by: ammar <[email protected]>
# Conflicts:
#	keiko/poetry.lock
# Conflicts:
#	boefjes/poetry.lock
#	boefjes/pyproject.toml
#	bytes/poetry.lock
#	bytes/pyproject.toml
#	keiko/poetry.lock
#	keiko/pyproject.toml
#	keiko/requirements-dev.txt
#	keiko/requirements.txt
#	rocky/poetry.lock
Signed-off-by: ammar <[email protected]>
dekkers
dekkers previously approved these changes Nov 30, 2023
# Conflicts:
#	boefjes/poetry.lock
#	bytes/poetry.lock
…x/upgrade-pydantic-v2

# Conflicts:
#	bytes/poetry.lock
#	bytes/requirements-dev.txt
#	bytes/requirements.txt
@underdarknl underdarknl merged commit 6cc27cd into main Dec 5, 2023
75 of 76 checks passed
@underdarknl underdarknl deleted the fix/upgrade-pydantic-v2 branch December 5, 2023 11:05
jpbruinsslot added a commit that referenced this pull request Dec 6, 2023
* main: (25 commits)
  Create object history API (#2074)
  Bump actions/github-script from 6 to 7 (#2076)
  Installation manual for Windows (2) (#2096)
  Update howdoesitwork.rst (#2091)
  Add benchmarking script to the scheduler (#2071)
  Add fix-poetry-merge-conflict makefile command (#2088)
  Bump sphinx-rtd-theme from 1.2.2 to 2.0.0 (#2080)
  Lower quality level so the CI check doesn't fail (#2086)
  Update xtdb version in octopoes CI docker compose and docker-compose.release-example.yml (#2085)
  Name test nodes by testname instead of uuid (#2087)
  Upgrade to Pydantic v2 (#1912)
  Docs: add dependency installation commands for RHEL based systems (#2059)
  Fix/2072 (#2082)
  Feature/service to systems reports rocky (#2073)
  Update scheduler python packages (#2062)
  Add uvicorn back as non-dev dependency (#2053)
  Bump `cryptography` (#2070)
  Filter tree objects with depth=1 for Findings  (#1982)
  Bump aiohttp from 3.8.6 to 3.9.0 in /boefjes (#2061)
  Translations update from Hosted Weblate (#2057)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Pydantic v2
6 participants