Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Control Panel to Assume Role in Parent Account #6569

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

julialawrence
Copy link
Contributor

Pull Request Objective

This piece of work is being tracked in
this
GitHub Issue.

This allows the control panel dev and prod roles to assume the role in the parent account in order to add/remove and manage quicksight users.

Checklist

Note

Each items should be checked. Skipping below checks could delay your PR review!

  • I have reviewed the style guide
    and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've
    used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

Additional Comments

@julialawrence julialawrence requested a review from a team as a code owner January 16, 2025 11:42
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Terraform Component 🧱: aws-analytical-platform-production-cluster

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @julialawrence, Action: pull_request, Working Directory: terraform/aws/analytical-platform-production/cluster, Workflow: Terraform, Marker: aws-analytical-platform-production-cluster_static_analysis

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Terraform Component 🧱: aws-analytical-platform-development-cluster

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @julialawrence, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_static_analysis

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Terraform Component 🧱: aws-analytical-platform-development-cluster

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @julialawrence, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_plan

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Terraform Component 🧱: aws-analytical-platform-production-cluster

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @julialawrence, Action: pull_request, Working Directory: terraform/aws/analytical-platform-production/cluster, Workflow: Terraform, Marker: aws-analytical-platform-production-cluster_plan

Copy link
Contributor

@jamesstottmoj jamesstottmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julialawrence julialawrence merged commit d247321 into main Jan 16, 2025
16 checks passed
@julialawrence julialawrence deleted the feature/allow-control-panel-to-assume-org-role branch January 16, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants