Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bedrock batch inference #6524

Merged
merged 12 commits into from
Jan 15, 2025
Merged

Bedrock batch inference #6524

merged 12 commits into from
Jan 15, 2025

Conversation

Emterry
Copy link
Contributor

@Emterry Emterry commented Jan 8, 2025 •
edited
Loading

Pull Request Objective

Adding necessary roles and policies to allow Bedrock batch inference to be consumed by users

This piece of work is being tracked in this issue #6253

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

Terraform Component 🧱: aws-analytical-platform-development-cluster

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @Emterry, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_static_analysis

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

Terraform Component 🧱: aws-analytical-platform-development-cluster

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @Emterry, Action: pull_request, Working Directory: terraform/aws/analytical-platform-development/cluster, Workflow: Terraform, Marker: aws-analytical-platform-development-cluster_plan

@Emterry Emterry marked this pull request as ready for review January 10, 2025 14:19
@Emterry Emterry requested a review from a team as a code owner January 10, 2025 14:19
julialawrence
julialawrence requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks technically sound which is awesome.

There are naming inconsistencies here between resources, which makes tracking which policy and document does what difficult. I made some suggestions around the naming of the s3 access policies but the bedrock doc/policy/role/attachment need to be fixed up.
Most importantly, I am not sure this belongs in the cluster section. These are tooling-related resources, they should be in tooling-iam folder.

terraform/aws/analytical-platform-development/cluster/iam-policies.tf Outdated Show resolved Hide resolved
terraform/aws/analytical-platform-development/cluster/iam-policies.tf Outdated Show resolved Hide resolved
terraform/aws/analytical-platform-development/cluster/iam-policies.tf Outdated Show resolved Hide resolved
terraform/aws/analytical-platform-development/cluster/iam-policies.tf Outdated Show resolved Hide resolved
terraform/aws/analytical-platform-development/cluster/iam-policies.tf Outdated Show resolved Hide resolved
julialawrence
julialawrence approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Emterry Emterry merged commit 764c33a into main Jan 15, 2025
13 checks passed
@Emterry Emterry deleted the bedrock-batch-inference branch January 15, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julialawrence julialawrence julialawrence approved these changes

Assignees

@Emterry Emterry

Labels
override-static-analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emterry @julialawrence