Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix catalogue name and page search #3381

Merged
merged 8 commits into from
Feb 19, 2024

Conversation

LavMatt
Copy link
Contributor

@LavMatt LavMatt commented Feb 16, 2024

fixes a few minor bugs (fixes #3328 and others without ticket)

  • search page corrected as start refers to individual result index rather than result page
  • dataset name was not added to datahub - corrected
  • data product assets were duplicated when appended to existing assets

@LavMatt LavMatt marked this pull request as ready for review February 19, 2024 09:51
@LavMatt LavMatt requested a review from a team February 19, 2024 09:51
Copy link
Contributor

@tom-webber tom-webber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LavMatt LavMatt merged commit 9aa5604 into main Feb 19, 2024
17 checks passed
@LavMatt LavMatt deleted the bug-fix-catalogue-name-and-page-search branch February 19, 2024 10:12
Copy link
Contributor

@MatMoore MatMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Our python datahub search client does not return correct page search results
3 participants