dont check --batch/--concurrent/--objects consistency with --list-existing #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
approved these changes
Nov 19, 2024
|
I've added an exclusion on the linter and #350 cames up in the mean time. I'll remove the last commit once the PR is mergerd |
klauspost
reviewed
Nov 19, 2024
Comment on lines
+37
to
+38
| - redefinition of the built-in function max | ||
| - redefinition of the built-in function min |
There was a problem hiding this comment.
We've fixed it. Please revert.
Suggested change
| - redefinition of the built-in function max | |
| - redefinition of the built-in function min |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
--list-existingis set there's not need to ensure--batch,--concurrentand--objectsvalues are consistent.