Skip to content

Commit

Permalink
Set a default concurrency of 20 (#151)
Browse files Browse the repository at this point in the history
Let's make the benchmark machine independent by default.
  • Loading branch information
klauspost authored Nov 19, 2020
1 parent 2e2e46e commit bd355e7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ This will run the benchmark for up to 5 minutes and print the results.

# Benchmarks

All benchmarks operate concurrently.
By default the processor determines the number of operations that will be running concurrently.
All benchmarks operate concurrently. By default, 20 operations will run concurrently.
This can however also be tweaked using the `--concurrent` parameter.

Tweaking concurrency can have an impact on performance, especially if latency to the server is tested.
Expand Down
3 changes: 1 addition & 2 deletions cli/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ package cli
import (
"fmt"
"os"
"runtime"

"github.com/minio/cli"
"github.com/minio/minio/pkg/console"
Expand Down Expand Up @@ -194,7 +193,7 @@ var ioFlags = []cli.Flag{
},
cli.IntFlag{
Name: "concurrent",
Value: runtime.GOMAXPROCS(0),
Value: 20,
Usage: "Run this many concurrent operations",
},
cli.BoolFlag{
Expand Down

0 comments on commit bd355e7

Please sign in to comment.