touch_handler: Fix scroll up behavior on Firefox Android #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the touchmove listener is registered with passive: false, scrolling up on Firefox Android only works every other attempt. When scrolling breaks, the touchmove callback is never invoked. The passive flag was originally set to false as part of a fix to prevent vertical scrolling while swiping: 3f31744. Setting passive to true doesn't seem to negatively affect that in both Firefox and Chrome, but fixes the scoll up behavior on Firefox. Fixes: miniflux#2053 Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
touchmovelistener is registered withpassive: false, scrolling up on Firefox Android only works every other attempt. When scrolling breaks, thetouchmovecallback is never invoked.The
passiveflag was originally set to false as part of a fix to prevent vertical scrolling while swiping: 3f31744. Settingpassiveto true doesn't seem to negatively affect that in both Firefox and Chrome, but fixes the scoll up behavior on Firefox.Fixes: #2053
Do you follow the guidelines?